Bug 263748 – [GeometryInterface] Add `scaleNonUniform` in DOMMatrixReadOnly

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ahmad Saleem]

Hi,

We should add 'scaleNonUniform' support.

Web-Spec: https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scalenonuniform

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/57f350e070536c7870cad53b3edf74f58cc51d50

We are failing WPT test cases due to lack of support and adding them will progress them.

I was not able to find relevant bug so created new.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/117875678>

[Ahmad Saleem]

>> Source/WebCore/css/DOMMatrixReadOnly.cpp

Ref<DOMMatrix> DOMMatrixReadOnly::scaleNonUniform(double scaleX, double scaleY)
{
    auto matrix = cloneAsDOMMatrix();
    return matrix->scaleSelf(scaleX, scaleY, 1, 0, 0, 0);
}

>> Source/WebCore/css/DOMMatrixReadOnly.h:

Ref<DOMMatrix> scaleNonUniform(double scaleX = 1, double scaleY = 1);

>> Source/WebCore/css/DOMMatrixReadOnly.idl:

[NewObject] DOMMatrix scaleNonUniform(optional unrestricted double scaleX = 1,
                                      optional unrestricted double scaleY = 1);

___

This compiles and progress few tests cases.

I can sync 'WPT' and do above to at least progress few tests cases and as for remaining, I am happy to create separate bugs.

[Karl Dubost]

if it doesn't regress anything, let's do it.
what are the WPT tests progressing? 
ah probably these https://wpt.fyi/results/css/geometry?label=master&label=experimental&aligned&q=safari%3Afail

[EWS]

Committed 271030@main (d0f9805c729a): <https://commits.webkit.org/271030@main>

Reviewed commits have been landed. Closing PR #20799 and removing active labels.