The global variables need to be removed from bidi.cpp.
Created attachment 31228 [details] Patch
Created attachment 31229 [details] Patch
Comment on attachment 31229 [details] Patch > + if (lBreak.obj && lineMidpointState.m_numMidpoints && lineMidpointState.m_numMidpoints % 2 == 0) { The style guidelines say you should avoid == 0 and use !(lineMidpointState.m_numMidpoints % 2). > + if (lineMidpointState.m_numMidpoints % 2 == 1) { Here you can just omit the == 1. > - chopMidpointsAt(lBreak.obj, lBreak.pos-2); > + chopMidpointsAt(lineMidpointState, lBreak.obj, lBreak.pos-2); Please add spaces around the -. r=me assuming layout tests pass. This code is kinda hot so it would be good to verify that any changes do not cause a perf regression.
Fixed in r44649.