WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26367
Remove the globals from bidi.cpp
https://bugs.webkit.org/show_bug.cgi?id=26367
Summary
Remove the globals from bidi.cpp
Dave Hyatt
Reported
2009-06-12 22:22:03 PDT
The global variables need to be removed from bidi.cpp.
Attachments
Patch
(31.08 KB, patch)
2009-06-12 22:22 PDT
,
Dave Hyatt
no flags
Details
Formatted Diff
Diff
Patch
(29.48 KB, patch)
2009-06-12 22:45 PDT
,
Dave Hyatt
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2009-06-12 22:22:35 PDT
Created
attachment 31228
[details]
Patch
Dave Hyatt
Comment 2
2009-06-12 22:45:24 PDT
Created
attachment 31229
[details]
Patch
mitz
Comment 3
2009-06-12 22:58:43 PDT
Comment on
attachment 31229
[details]
Patch
> + if (lBreak.obj && lineMidpointState.m_numMidpoints && lineMidpointState.m_numMidpoints % 2 == 0) {
The style guidelines say you should avoid == 0 and use !(lineMidpointState.m_numMidpoints % 2).
> + if (lineMidpointState.m_numMidpoints % 2 == 1) {
Here you can just omit the == 1.
> - chopMidpointsAt(lBreak.obj, lBreak.pos-2); > + chopMidpointsAt(lineMidpointState, lBreak.obj, lBreak.pos-2);
Please add spaces around the -. r=me assuming layout tests pass. This code is kinda hot so it would be good to verify that any changes do not cause a perf regression.
Dave Hyatt
Comment 4
2009-06-12 23:04:51 PDT
Fixed in
r44649
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug