Bug 263604 - Change ExpressionRangeInfo's divot, startOffset, and endOffset to be of type unsigned.
Summary: Change ExpressionRangeInfo's divot, startOffset, and endOffset to be of type ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-24 11:43 PDT by Mark Lam
Modified: 2023-10-24 15:48 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-10-24 11:43:27 PDT 
They are currently type int.  However, they were always stored and actually ever populated with positive integer values (i.e. unsigned).  We should make it clear that they are meant to contain unsigned values.
Comment 1 Radar WebKit Bug Importer 2023-10-24 11:43:49 PDT 
<rdar://problem/117427783>
Comment 2 Mark Lam 2023-10-24 11:51:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19503
Comment 3 EWS 2023-10-24 15:48:18 PDT 
Committed 269738@main (dd31388a0aef): <https://commits.webkit.org/269738@main>

Reviewed commits have been landed. Closing PR #19503 and removing active labels.