WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26360
UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26360
Summary
UString shouldn't create sharedBuffer for SmallStrings.
David Levin
Reported
2009-06-12 16:18:58 PDT
The problem is that UString::sharedBuffer() is using the length of the BaseString which is 256 for SmallStrings as opposed to Rep::len, the length of the string being shared (which is 1 for SmallStrings).
Attachments
Proposed fix.
(5.62 KB, patch)
2009-06-12 16:32 PDT
,
David Levin
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2009-06-12 16:32:58 PDT
Created
attachment 31220
[details]
Proposed fix.
David Levin
Comment 2
2009-06-12 17:53:12 PDT
Committed as
http://trac.webkit.org/changeset/44641
. And a follow up change to fix the dll exports on windows:
http://trac.webkit.org/changeset/44642
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug