WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
263578
Rename webrtc::pixelBufferFrom* functions to have 'create' in the name and fix a CVPixelBufferRef leak
https://bugs.webkit.org/show_bug.cgi?id=263578
Summary
Rename webrtc::pixelBufferFrom* functions to have 'create' in the name and fi...
Simon Fraser (smfr)
Reported
2023-10-23 20:33:56 PDT
These functions return retained values, so should have 'create' in the name: CVPixelBufferRef pixelBufferFromI420Buffer(const uint8_t* buffer, size_t length, size_t width, size_t height, I420BufferLayout) CF_RETURNS_RETAINED; CVPixelBufferRef pixelBufferFromI420ABuffer(const uint8_t* buffer, size_t length, size_t width, size_t height, I420ABufferLayout) CF_RETURNS_RETAINED;
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-10-23 20:34:15 PDT
<
rdar://problem/117388614
>
Simon Fraser (smfr)
Comment 2
2023-10-23 20:35:50 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/19471
EWS
Comment 3
2023-10-24 20:12:42 PDT
Committed
269747@main
(11a2ba1a7a1c): <
https://commits.webkit.org/269747@main
> Reviewed commits have been landed. Closing PR #19471 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug