RESOLVED FIXED 263497
Assess and remove libxml2 hacks called 'hackAroundLibXMLEntityBug' and 'hackAroundLibXMLEntityParsingBug' 
https://bugs.webkit.org/show_bug.cgi?id=263497
Summary Assess and remove libxml2 hacks called 'hackAroundLibXMLEntityBug' and 'hackA...
Ahmad Saleem
Reported 2023-10-21 10:58:36 PDT
Hi Team, These hacks were added long time back and I think all WebKit embedder ports and dependencies would be updated and we might not need these hacks anymore: They were removed from Blink in 2013: Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=149452 & Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=149412 ___ Just wanted to raise so we can explore and delete them. This is just clean-up proposal in code. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2023-10-21 16:08:09 PDT
@Fuji, @Don & @Michael - Any comments from your side on GTK, WPE and Win-Cairo port?
Michael Catanzaro
Comment 2 2023-10-21 17:48:32 PDT
Go ahead and remove them. Surely none of us still care about libxml from 2009.
David Kilzer (:ddkilzer)
Comment 3 2023-10-22 09:00:17 PDT
Yes, it's fine to remove them.
EWS
Comment 4 2023-10-23 14:02:12 PDT
Committed 269666@main (2b4d9ac4ad72): <https://commits.webkit.org/269666@main> Reviewed commits have been landed. Closing PR #19397 and removing active labels.
Radar WebKit Bug Importer
Comment 5 2023-10-23 14:03:15 PDT
<rdar://problem/117371488>
Note You need to log in before you can comment on or make changes to this bug.