Bug 26345 – build-webkit script has wrong default options for the Qt port, and the options are not passed on to qmake

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Tor Arne Vestbø]

Defaults are not picked up from the pro file, and none of the options are passed on to the Qt build system

[Tor Arne Vestbø]

Created attachment 31197 [details]
Fix Qt problems in build-webkit script

This patch fixes the Qt problems in build-webkit by running a quick pass of qmake and then parsing out the feature defaults. It then passes these on to qmake again in the real pass if they are different from the defaults.

The patch also involves refactoring of the build-webkit-script to remove redundant definitions of the options.

[Tor Arne Vestbø]

GTK bits reviewed by Xan Lopez
Qt bits reviewed by Simon Hausmann

[Tor Arne Vestbø]

Created attachment 31198 [details]
Fix bug when shadow-building

Same as above patch, but does a chdirWebKit() as early as possible so that code that expects to run within the webkit source tree works (such as the qtFeatureDefaults() function).

[Andre Pedralho]

Are bugs #26223 and #26224 related to this? Or maybe include them?

[Tor Arne Vestbø]

Yepp, related. Will take a look and land on top of this one.

[Mark Rowe (bdash)]

Comment on attachment 31198 [details]
Fix bug when shadow-building

> +
> +        WARNING: NO TEST CASES ADDED OR CHANGED
> +

You should remove this line. It's emitted only as a reminder to the patch author.

r=me

[Tor Arne Vestbø]

Landed in r44681. The Mac/Win buildbot seems to be down at the moment, but built Mac port locally without problems. Will track and see if this caused any breakages (GTK built fine).