WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 263448
Build fix: add gtest dependency to gmock project
https://bugs.webkit.org/show_bug.cgi?id=263448
Summary
Build fix: add gtest dependency to gmock project
David Kilzer (:ddkilzer)
Reported
2023-10-20 09:47:30 PDT
Build fix: add gtest dependency to gmock project. The gmock project depends on headers from the gtest project, but Xcode is not aware of this dependency, so gmock can sometimes build before gtest, resulting in a build failure: ``` In file included from OpenSource/Source/ThirdParty/gmock/src/gmock-all.cc:39: In file included from include/gmock/gmock.h:59: In file included from include/gmock/gmock-actions.h:145: In file included from include/gmock/internal/gmock-internal-utils.h:46: include/gmock/internal/gmock-port.h:56:10: fatal error: 'gtest/internal/gtest-port.h' file not found #include <gtest/internal/gtest-port.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/gmock/internal/gmock-port.h:56:10: note: did not find header 'internal/gtest-port.h' in framework 'gtest' (loaded from 'OpenSource/WebKitBuild/Release') 1 error generated. ```
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-10-20 09:47:45 PDT
<
rdar://problem/117266314
>
David Kilzer (:ddkilzer)
Comment 2
2023-10-20 10:21:59 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/19347
EWS
Comment 3
2023-10-20 13:04:08 PDT
Committed
269581@main
(14adb9294c87): <
https://commits.webkit.org/269581@main
> Reviewed commits have been landed. Closing PR #19347 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug