Bug 263403 – AX: AXIsolatedTree::createEmptyContent takes too long.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

This method should create just 2 AXIsolatedObjects, but it is still taking too long.

[Radar WebKit Bug Importer]

<rdar://problem/117224271>

[Andres Gonzalez]

Created attachment 468279 [details]
Patch

[chris fleizach]

Comment on attachment 468279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468279&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:99
> +    m_emptyContentTree = true;

where do we set this to false?

[Andres Gonzalez]

(In reply to chris fleizach from comment #3)
> Comment on attachment 468279 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=468279&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:99
> > +    m_emptyContentTree = true;
> 
> where do we set this to false?

Never, the empty content tree is replaced with the full tree, not populated.

[Andres Gonzalez]

Created attachment 468304 [details]
Patch

[Tyler Wilcock]

Comment on attachment 468304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468304&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:369
> +    bool m_emptyContentTree { false };

Thoughts on m_isEmptyContentTree to match the member function, and to satisfy the style guide?

https://webkit.org/code-style-guidelines/#names-bool

> Precede boolean values with words like “is” and “did”.

[Andres Gonzalez]

Created attachment 468308 [details]
Patch

[EWS]

Committed 269708@main (329677707e94): <https://commits.webkit.org/269708@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468308 [details].