Bug 263368 - [CoordinatedGraphics] Remove CompositingCoordinator::syncLayerState()
Summary: [CoordinatedGraphics] Remove CompositingCoordinator::syncLayerState()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2023-10-19 02:24 PDT by Carlos Garcia Campos
Modified: 2023-10-20 04:32 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-10-19 02:24:21 PDT 
The coordinator calls syncPendingStateChangesIncludingSubLayers on the root graphics layer, that doesn't really sync anything, every layer checks if there's a pending stater sync and calls CompositingCoordinator::syncLayerState() to mark m_shouldSyncFrame as true. We can remove the dependency of the layer on the compositor by making syncPendingStateChangesIncludingSubLayers return whether the sync should happen or not.
Comment 1 Carlos Garcia Campos 2023-10-19 02:27:39 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19275
Comment 2 EWS 2023-10-20 04:30:21 PDT 
Committed 269560@main (5a023aa72619): <https://commits.webkit.org/269560@main>

Reviewed commits have been landed. Closing PR #19275 and removing active labels.