Bug 263367 - fast/attachment tests cannot run with reftest-wait on WK1
Summary: fast/attachment tests cannot run with reftest-wait on WK1
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gerald Squelart
URL:
Keywords: InRadar
Depends on: 262978 263085
Blocks:
  Show dependency tree / graph
 
Reported: 2023-10-19 01:59 PDT by Gerald Squelart
Modified: 2023-10-23 14:49 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Squelart 2023-10-19 01:59:09 PDT 
Following bug 262978, attachment-icon-from-file-extension.html should now properly work on WK2, including waiting for the icon to load before taking the screenshot. Previously the icon could be missing, leading to intermittent failures.

However since then, this test cannot run on WK1 anymore, it times out.
Based on some minimal logging, my guess at this time is that because of the "reftest-wait", there is no rendering at all, meaning the attachment rendering does not run even once, which is when the icon is first requested.
Ideally it would be nice to trigger an initial rendering before the final screenshot rendering. If that's not possible, maybe the icon will have to be fetched eagerly, but that would modify the behavior. To be investigated further...
Comment 1 Radar WebKit Bug Importer 2023-10-19 01:59:22 PDT 
<rdar://problem/117193571>
Comment 2 Gerald Squelart 2023-10-23 14:49:21 PDT 
Expanding this bug to cover all tests that would want to use reftest-wait on WK1.

https://bugs.webkit.org/show_bug.cgi?id=263085 for fast/attachment/attachment-uti.html