RESOLVED FIXED 263216
Stop using StringView::operator[] in hot code paths in WebCore 
https://bugs.webkit.org/show_bug.cgi?id=263216
Summary Stop using StringView::operator[] in hot code paths in WebCore
Chris Dumez
Reported 2023-10-16 14:02:16 PDT
Stop using StringView::operator[] in hot code paths in WebCore. StringView's operator[] is not super efficient because it needs to check the is8Bit flag for every character when iterating. I am also looking into adding a boundary check in StringView::operator[], which would further increase branching.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2023-10-16 14:08:19 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19130
EWS
Comment 2 2023-10-16 21:45:59 PDT
Committed 269396@main (9ad44599784a): <https://commits.webkit.org/269396@main> Reviewed commits have been landed. Closing PR #19130 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-10-16 21:47:16 PDT
<rdar://problem/117055068>
Note You need to log in before you can comment on or make changes to this bug.