Bug 26306 - DumpRenderTree crashes on Windows
Summary: DumpRenderTree crashes on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-10 16:31 PDT by John Abd-El-Malek
Modified: 2009-06-11 11:23 PDT (History)
4 users (show)

See Also:

Attachments
Added a patch (1.97 KB, patch)
2009-06-10 16:41 PDT, John Abd-El-Malek 		sfalken: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2009-06-10 16:31:21 PDT 
The problem is that CFURLCacheSharedURLCache isn't exported by the CoreNetwork.dll that comes with Safari 4.

Reverting 42565 fixes the issue.  Not sure if that's the long term solution, or the correct dll will be pushed out.
Comment 1 Eric Seidel (no email) 2009-06-10 16:41:37 PDT 
http://trac.webkit.org/changeset/42565
Comment 2 John Abd-El-Malek 2009-06-10 16:41:41 PDT 
Created attachment 31143 [details]
Added a patch

Not sure if the source should be updated, or whether there's a version of the DLLs coming out soon that's compatible.  At the very least, others who're having this issue can apply this patch.
Comment 3 Steve Falkenburg 2009-06-11 10:31:51 PDT 
Reverting that change seems fine for now, and will work both before and after we update the headers to CFNetwork used by the open source project.
Comment 4 Brent Fulgham 2009-06-11 11:20:19 PDT 
Committed in @r44609.
Comment 5 John Abd-El-Malek 2009-06-11 11:23:09 PDT 
Thanks for committing it for me.