Bug 263051 – return a createCommaSeparated() in CSSPropertyBackgroundBlendMode

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Karl Dubost]

Created attachment 468182 [details]
testcase

Currently the CSSPropertyBackgroundBlendMode, returns a space separated list instead of comma separated list

-        return CSSValueList::createSpaceSeparated(WTFMove(list));
+        return CSSValueList::createCommaSeparated(WTFMove(list));


Uploaded Simple Test by Simon Fraser.

It should return: 
   "normal, luminosity"
and not
   "normal luminosity"

[Radar WebKit Bug Importer]

<rdar://problem/116838342>

[Karl Dubost]

Pull request: https://github.com/WebKit/WebKit/pull/18971

[Ahmad Saleem]

@Karl - will it progress following three failing tests:

https://wpt.fyi/results/css/compositing/parsing/background-blend-mode-computed.html?label=master&label=experimental&aligned=&q=safari%3Afail

[Karl Dubost]

See Bug 261552 (and my new coming comment there) ;)

[Ahmad Saleem]

(In reply to Karl Dubost from comment #4)
> See Bug 261552 (and my new coming comment there) ;)

Sweet!! :-)

[Karl Dubost]

Note tests will be fixed/extended in 
https://github.com/web-platform-tests/wpt/issues/42496

[EWS]

Committed 269325@main (c7bdf3966172): <https://commits.webkit.org/269325@main>

Reviewed commits have been landed. Closing PR #18971 and removing active labels.