Bug 263034 - Element::dispatchMouseEvent should return whether an event is prevented default
Summary: Element::dispatchMouseEvent should return whether an event is prevented default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Abrar Rahman Protyasha
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-11 13:30 PDT by Abrar Rahman Protyasha
Modified: 2023-10-12 12:42 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abrar Rahman Protyasha 2023-10-11 13:30:44 PDT 
Following the changes in bug 262691, `Element::dispatchMouseEvent` uses an out param to indicate whether an event is cancelled. This method should instead be changed to return some structure like `std::pair<bool, IsEventPreventDefaulted>` instead, and then have all callers adopt accordingly.
Comment 1 Radar WebKit Bug Importer 2023-10-12 06:07:16 PDT 
<rdar://problem/116859739>
Comment 2 Abrar Rahman Protyasha 2023-10-12 06:18:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18994
Comment 3 EWS 2023-10-12 12:42:34 PDT 
Committed 269266@main (b5ebe19c2491): <https://commits.webkit.org/269266@main>

Reviewed commits have been landed. Closing PR #18994 and removing active labels.