Bug 263010 - Remove Construct 3 OffscreenCanvas quirk
Summary: Remove Construct 3 OffscreenCanvas quirk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Safari 17
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Karl Dubost
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-11 06:18 PDT by Ashley Gullen
Modified: 2023-11-20 20:25 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ashley Gullen 2023-10-11 06:18:26 PDT
Safari 16.4 shipped only the 2D context for OffscreenCanvas. This broke all Construct 3 content since it expected WebGL support with OffscreenCanvas (issue 253431). Apple worked around this by adding a quirk to detect Construct 3 and disable OffscreenCanvas.

Safari 17 has now shipped with WebGL support with OffscreenCanvas so this quirk is no longer necessary, and may impede future development work which depends on OffscreenCanvas support. So, please remove the quirk.
Comment 1 Karl Dubost 2023-10-11 08:55:51 PDT
See https://github.com/apple/WebKit/pull/445/files
Comment 2 Radar WebKit Bug Importer 2023-10-18 06:19:14 PDT
<rdar://problem/117130090>
Comment 3 Ashley Gullen 2023-11-17 07:37:30 PST
I haven't heard anything back for a month and we need to move forward here, so we're changing our engine to bypass Safari's detection and make sure we can get OffscreenCanvas re-enabled. FWIW we have updated the feature detection to make sure WebGL works in OffscreenCanvas in a worker. I guess that makes this issue a bit of a moot point now. Maybe just leave the hack in for older content.
Comment 4 Karl Dubost 2023-11-20 15:34:44 PST
Pull request: https://github.com/WebKit/WebKit/pull/20766
Comment 5 Karl Dubost 2023-11-20 15:36:12 PST
Ashley, Thanks for the reminder. It slipped through my fingers.
Comment 6 EWS 2023-11-20 20:25:00 PST
Committed 270998@main (52fe5506bfda): <https://commits.webkit.org/270998@main>

Reviewed commits have been landed. Closing PR #20766 and removing active labels.