Bug 262990 - AX: AccessibilityObject::listMarkerTextForNodeAndPosition(Node*, Position&&) should not resolve a VisiblePosition if there is no marker
Summary: AX: AccessibilityObject::listMarkerTextForNodeAndPosition(Node*, Position&&) ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-10 17:54 PDT by Tyler Wilcock
Modified: 2023-10-11 11:01 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.22 KB, patch)
2023-10-10 18:02 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (2.22 KB, patch)
2023-10-10 18:03 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (2.22 KB, patch)
2023-10-10 18:06 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (2.19 KB, patch)
2023-10-10 18:21 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-10-10 17:54:29 PDT 
Resolving a Position to a VisiblePosition can be extraordinarily expensive. Only do it when absolutely necessary.
Comment 1 Radar WebKit Bug Importer 2023-10-10 17:54:47 PDT 
<rdar://problem/116780655>
Comment 2 Tyler Wilcock 2023-10-10 18:02:35 PDT 
Created attachment 468163 [details]
Patch
Comment 3 Tyler Wilcock 2023-10-10 18:03:21 PDT 
Created attachment 468164 [details]
Patch
Comment 4 Tyler Wilcock 2023-10-10 18:06:38 PDT 
Created attachment 468165 [details]
Patch
Comment 5 Tyler Wilcock 2023-10-10 18:21:07 PDT 
Created attachment 468166 [details]
Patch
Comment 6 EWS 2023-10-11 11:01:04 PDT 
Committed 269208@main (612749994064): <https://commits.webkit.org/269208@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468166 [details].