Faulty logic in AccessibilityRenderObject::isSelected

[Xan Lopez]

Code is:

bool AccessibilityRenderObject::isSelected() const
{
    if (!m_renderer)
        return false;
    
    Node* node = m_renderer->node();
    if (!node)
        return false;
    
    return false;
}

I'm not sure if the last 'false' was meant to be 'true', but in any case it seems to me the function can't be right. My naive implementation of this would be to get the VisibleSelection and check if isNone() is true, but I'm sure there's better ways of doing it.

[chris fleizach]

i think the last false is OK, since we don't want to return true for default for isSelected

there's obviously something missing though that should return true for some state. 

This isSelected does not correspond to the selection (at least on the mac... that's represented by AXSelectedTextRange). it's used more in the context of a multi-select list where one of the list items is selected (i'm pretty sure that AccessibilityListBoxOption overrides this method)

So while this code does not necessarily look correct, I'm not sure what elements WebKit does want to return true for isSelected... if we identify those elements and their states, we would want to change that

[James Craig]

<rdar://problem/15113521>

[chris fleizach]

isSelected() is not meant to be the TextSelection. It's for things like aria-selected=true