Bug 26296 - REGRESSION: can't type in un-disabled textarea
Summary: REGRESSION: can't type in un-disabled textarea
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-10 12:13 PDT by Ojan Vafai
Modified: 2009-06-10 14:56 PDT (History)
2 users (show)

See Also:


Attachments
Fix collapsing empty shadow nodes in textareas. (3.70 KB, patch)
2009-06-10 12:22 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Fix collapsing empty shadow nodes in textareas. (3.81 KB, patch)
2009-06-10 12:31 PDT, Ojan Vafai
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2009-06-10 12:13:43 PDT
Enabling a disabled, empty textarea leaves it untypeable. Patch + test coming soon.
Comment 1 Ojan Vafai 2009-06-10 12:22:36 PDT
Created attachment 31137 [details]
Fix collapsing empty shadow nodes in textareas.
Comment 2 Ojan Vafai 2009-06-10 12:28:08 PDT
Comment on attachment 31137 [details]
Fix collapsing empty shadow nodes in textareas.

Those expected results are bogus. Sorry about that. New patch coming in 1 min.
Comment 3 Ojan Vafai 2009-06-10 12:31:32 PDT
Created attachment 31138 [details]
Fix collapsing empty shadow nodes in textareas.
Comment 4 Eric Seidel (no email) 2009-06-10 14:44:23 PDT
Comment on attachment 31138 [details]
Fix collapsing empty shadow nodes in textareas.

Looks sane to me.  Test could be a js test, but this looks good too. :)
Comment 5 Ojan Vafai 2009-06-10 14:47:42 PDT
Yeah, I was going to write it as a JS test, but JS tests still don't deal properly with tests that use setTimeouts. Didn't seem worth the effort to fix now.
Comment 6 Ojan Vafai 2009-06-10 14:56:12 PDT
http://trac.webkit.org/changeset/44593