Bug 262944 - [GTK] Simplify handling of toplevel window signals
Summary: [GTK] Simplify handling of toplevel window signals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2023-10-10 01:37 PDT by Carlos Garcia Campos
Modified: 2023-10-10 05:23 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-10-10 01:37:54 PDT 
We currently track the state of the toplevel window from every web view, connecting to the same signals to be notified when something changes. We could add a toplevel window wrapper instead to track its state and notify all the web views when there's any change.
Comment 1 Carlos Garcia Campos 2023-10-10 01:40:49 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18886
Comment 2 EWS 2023-10-10 05:23:16 PDT 
Committed 269136@main (c4614fd4f2f2): <https://commits.webkit.org/269136@main>

Reviewed commits have been landed. Closing PR #18886 and removing active labels.