Bug 26294 - Uninitialized memory read copying ResourceResponse
Summary: Uninitialized memory read copying ResourceResponse
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Barth
Depends on:
Reported: 2009-06-10 09:47 PDT by Darin Fisher (:fishd, Google)
Modified: 2009-06-13 21:42 PDT (History)
2 users (show)

See Also:

v1 patch (2.11 KB, patch)
2009-06-10 10:10 PDT, Darin Fisher (:fishd, Google)
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-06-10 09:47:14 PDT
Uninitialized memory read copying ResourceResponse

http://build.chromium.org/buildbot/waterfall/builders/Webkit (purify)/builds/7557/steps/purify test: test_shell/logs/stdio

This started failing somewhere between r44438 and r55455.

Looking at ResourceResponseBase.cpp, it looks like m_lastModifiedDate is never initialized.  This seems like a regression from r44453.
Comment 1 Darin Fisher (:fishd, Google) 2009-06-10 09:51:08 PDT
r44452 added a bunch of other member vars that are similarly uninitialized.
Comment 2 Darin Fisher (:fishd, Google) 2009-06-10 10:10:11 PDT
Created attachment 31134 [details]
v1 patch
Comment 3 Dimitri Glazkov (Google) 2009-06-10 10:11:27 PDT
Comment on attachment 31134 [details]
v1 patch

Comment 4 Eric Seidel (no email) 2009-06-12 15:47:45 PDT
Patch is not made from the root, so my fancy auto-commit script (bug 26283) can't handle it yet. :(
Comment 5 Adam Barth 2009-06-13 21:27:34 PDT
Will land.
Comment 6 Adam Barth 2009-06-13 21:42:54 PDT
This patch is already in the tree.  Not sure what revision.