Bug 26291 - [Qt] build break in ImageDecoderQt.cpp.
Summary: [Qt] build break in ImageDecoderQt.cpp.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-06-10 08:33 PDT by Yongjun Zhang
Modified: 2009-06-11 10:29 PDT (History)
0 users

See Also:


Attachments
quick patch to fix the build break. (2.14 KB, patch)
2009-06-10 08:40 PDT, Yongjun Zhang
eric: review+
Details | Formatted Diff | Diff
set m_isSizeAvailable to false when failed, to keep it consistent. (2.79 KB, patch)
2009-06-11 08:02 PDT, Yongjun Zhang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2009-06-10 08:33:14 PDT
ImageDecoder.h changes the visibility of m_size and m_isAvailable to private which breaks the compiling of ImageDecoderQt.cpp.
Comment 1 Yongjun Zhang 2009-06-10 08:40:30 PDT
Created attachment 31131 [details]
quick patch to fix the build break.
Comment 2 Eric Seidel (no email) 2009-06-11 01:07:40 PDT
Comment on attachment 31131 [details]
quick patch to fix the build break.

lgtm.
Comment 3 Yongjun Zhang 2009-06-11 08:02:10 PDT
Created attachment 31162 [details]
set m_isSizeAvailable to false when failed, to keep it consistent.
Comment 4 Peter Kasting 2009-06-11 10:15:24 PDT
Drive-by, since I wrote the new ImageDecoder.h code:

Remove the setSize(-1, -1) call from reset().  You can't have the size become _less_ available on receiving _more_ data; either the size was not yet set and remains unset, or it was already set and can remain set.

Remove "m_sizeAvailable = false;" from ImageDecoder.h.  This is inappropriate.
Comment 5 Ariya Hidayat 2009-06-11 10:29:06 PDT
A modified patch, after Peter's comment, is landed in r44605
http://trac.webkit.org/changeset/44605