WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
262872
[NativePromise] Shouldn't require to copy the resolved value when the promise isn't exclusive
https://bugs.webkit.org/show_bug.cgi?id=262872
Summary
[NativePromise] Shouldn't require to copy the resolved value when the promise...
Jean-Yves Avenard [:jya]
Reported
2023-10-08 23:33:59 PDT
Right now, when chaining promises that aren't exclusive, it requires to copy the resolve/reject value from one promise to the other as the promise itself owns the data that will be passed around. This prevents being able to chain promises for objects that do not have a copy constructor (like unique_ptr). Instead, we could either have the chained promise keeps a reference to the original promise, or store the data in a refcounted container and share that across instead.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-10-08 23:34:16 PDT
<
rdar://problem/116664254
>
Jean-Yves Avenard [:jya]
Comment 2
2023-10-09 07:47:45 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/18840
EWS
Comment 3
2023-10-11 23:22:41 PDT
Committed
269241@main
(c1b873c21745): <
https://commits.webkit.org/269241@main
> Reviewed commits have been landed. Closing PR #18840 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug