262868 – AX: All methods in AXIsolatedObject should be final, not override

Bug 262868 - AX: All methods in AXIsolatedObject should be final, not override

Summary: AX: All methods in AXIsolatedObject should be final, not override

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Accessibility (show other bugs)
Version:	Other
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Tyler Wilcock

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2023-10-08 12:21 PDT by Tyler Wilcock
Modified:	2023-10-08 16:37 PDT (History)
CC List:	10 users (show)

See Also:

Attachments
Patch (54.63 KB, patch) 2023-10-08 12:27 PDT, Tyler Wilcock	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tyler Wilcock 2023-10-08 12:21:48 PDT

This can help de-virtualize function calls:

https://github.com/llvm/llvm-project/blob/876334321f842edadcc0cd4241c76b59bb888b9e/clang/lib/AST/DeclCXX.cpp#L2260#L2261

Comment 1 Radar WebKit Bug Importer 2023-10-08 12:21:56 PDT

<rdar://problem/116650535>

Comment 2 Tyler Wilcock 2023-10-08 12:27:25 PDT

Created attachment 468115 [details]
Patch

Comment 3 EWS 2023-10-08 16:37:54 PDT

Committed 269059@main (db4f2bb7df50): <https://commits.webkit.org/269059@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468115 [details].