WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
262866
text-decoration-thickness should support percentages
https://bugs.webkit.org/show_bug.cgi?id=262866
Summary
text-decoration-thickness should support percentages
Tim Nguyen (:ntim)
Reported
2023-10-08 10:35:41 PDT
This should be pretty simple to support given we already support ems. Here are places that need changing:
https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/css/CSSProperties.json#8301-8305
https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/style/StyleBuilderConverter.h#881
https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/rendering/style/TextDecorationThickness.h
Attachments
Add attachment
proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1
2023-10-08 10:36:26 PDT
This should fix this WPT: imported/w3c/web-platform-tests/css/css-fonts/size-adjust-text-decoration.tentative.html
ChangSeok Oh
Comment 2
2023-10-12 10:49:41 PDT
I will take a look.
ChangSeok Oh
Comment 3
2023-10-12 10:53:06 PDT
By the way, is the name of size-adjust-text-decoration.tentative.html a mistake? Its reference file name is size-adjust-text-decoration-tentative-ref.html. Yeah, I am talking about the dot just before "tentative".
ChangSeok Oh
Comment 4
2023-10-14 09:36:19 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/19085
Radar WebKit Bug Importer
Comment 5
2023-10-15 10:36:13 PDT
<
rdar://problem/116985587
>
ChangSeok Oh
Comment 6
2023-10-15 17:47:15 PDT
***
Bug 255868
has been marked as a duplicate of this bug. ***
EWS
Comment 7
2023-10-28 04:16:17 PDT
Committed
269886@main
(4172b60326a8): <
https://commits.webkit.org/269886@main
> Reviewed commits have been landed. Closing PR #19085 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug