Bug 26284 - LayoutTests\editing\deleting\4875189.html should be a dumpAsText test instead of a pixel test
Summary: LayoutTests\editing\deleting\4875189.html should be a dumpAsText test instead...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 26225 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-09 17:32 PDT by Ryosuke Niwa
Modified: 2009-07-14 13:48 PDT (History)
0 users

See Also:


Attachments
This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test. (5.38 KB, patch)
2009-06-11 11:35 PDT, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2009-06-09 17:32:50 PDT
LayoutTests\editing\deleting\4875189.html
only tests whether the result consists of two paragraphs or not. It should be using a dumpAsText test instead.
Comment 1 Ryosuke Niwa 2009-06-11 11:35:47 PDT
Created attachment 31169 [details]
This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test.
Comment 2 Julie Parent 2009-06-11 12:04:15 PDT
Comment on attachment 31169 [details]
This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test.

>  <p>This test deletes the contents of a list, then it performs another delete, which should remove the empty list item. There should be two paragraphs below.</p>
>  <div id="div" contentEditable="true">Paragraph One.<ul><li id="li">bar</li></ul>Paragraph Two.</div>
> +<ol id="console"></ol>

Why is the console a list?
Comment 3 Eric Seidel (no email) 2009-06-11 12:06:25 PDT
Comment on attachment 31169 [details]
This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test.

Looks fine.
Comment 4 Ryosuke Niwa 2009-06-11 13:36:26 PDT
>Why is the console a list?

I'm not sure the original file had console as a list.  Maybe it's to do with reproducing the error.  It's maybe that making it div would affect the result.  e.g. it only occurs when there is exactly one div, or when it's the last div item in the page.
Comment 5 Julie Parent 2009-06-11 18:02:54 PDT
Committed as http://trac.webkit.org/changeset/44621
Comment 6 Alexey Proskuryakov 2009-07-14 13:48:54 PDT
*** Bug 26225 has been marked as a duplicate of this bug. ***