Bug 26284 – LayoutTests\editing\deleting\4875189.html should be a dumpAsText test instead of a pixel test

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

LayoutTests\editing\deleting\4875189.html
only tests whether the result consists of two paragraphs or not. It should be using a dumpAsText test instead.

[Ryosuke Niwa]

Created attachment 31169 [details]
This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test.

[Julie Parent]

Comment on attachment 31169 [details]
This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test.

>  <p>This test deletes the contents of a list, then it performs another delete, which should remove the empty list item. There should be two paragraphs below.</p>
>  <div id="div" contentEditable="true">Paragraph One.<ul><li id="li">bar</li></ul>Paragraph Two.</div>
> +<ol id="console"></ol>

Why is the console a list?

[Eric Seidel (no email)]

Comment on attachment 31169 [details]
This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test.

Looks fine.

[Ryosuke Niwa]

>Why is the console a list?

I'm not sure the original file had console as a list.  Maybe it's to do with reproducing the error.  It's maybe that making it div would affect the result.  e.g. it only occurs when there is exactly one div, or when it's the last div item in the page.

[Julie Parent]

Committed as http://trac.webkit.org/changeset/44621

[Alexey Proskuryakov]

*** Bug 26225 has been marked as a duplicate of this bug. ***