WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
262837
[GTK][WPE] Enable libbacktrace support
https://bugs.webkit.org/show_bug.cgi?id=262837
Summary
[GTK][WPE] Enable libbacktrace support
Philippe Normand
Reported
2023-10-07 02:24:00 PDT
The BuildStream SDK now ships libbacktrace so the support can be enabled in CMake.
Attachments
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2023-10-07 02:26:26 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/18807
EWS
Comment 2
2023-10-07 05:42:04 PDT
Committed
269037@main
(343ea784deb2): <
https://commits.webkit.org/269037@main
> Reviewed commits have been landed. Closing PR #18807 and removing active labels.
Philippe Normand
Comment 3
2023-10-07 07:09:42 PDT
This broke
https://build.webkit.org/#/builders/46
-- Could NOT find LibBacktrace (missing: LIBBACKTRACE_INCLUDE_DIR LIBBACKTRACE_LIBRARY) CMake Error at Source/cmake/OptionsGTK.cmake:478 (message): libbacktrace is required for USE_LIBBACKTRACE Call Stack (most recent call first): Source/cmake/WebKitCommon.cmake:232 (include) CMakeLists.txt:21 (include) Not sure what to do?
Philippe Normand
Comment 4
2023-10-07 07:11:13 PDT
https://build.webkit.org/#/builders/595
and
https://build.webkit.org/#/builders/68
also red
Michael Catanzaro
Comment 5
2023-10-07 08:02:03 PDT
Well we either change the LTS bots' configuration to build without libbacktrace, or install libbacktrace on the bots. I don't think this is urgent; they're not test bots, so it's not like we're losing test results every hour they are turned off. Can deal with it next week IMO.
Diego Pino
Comment 6
2023-10-08 08:24:13 PDT
FYI, an interruption of the WebKitGTK Ubuntu LTS build bot will likely cause an interruption of WebKit Search (
https://searchfox.org/wubkat/source/
) as well, because both bots build WebKitGTK with a similar configuration (--no-experimental-features plus a few features disabled). While the other bots are not critical, I think an interruption of WebKit Search is more important since many people use it daily. I searched for a libbacktrace package in Ubuntu and it doesn't seem to exist (neither 20.04 or 22.04). Libbakctrace is installed directly from a git repository (
https://github.com/WebKit/WebKit/blob/main/Tools/buildstream/elements/sdk/libbacktrace.bst
). A potential fix could be to install this package as a JHBuild dependency, but that wouldn't be enough for bots that do not use JHBuild and build only using system libraries (--no-experimental-features). In this case, those bots have to build with --USE_LIBBACKTRACE=OFF. I can change the bots settings to build with this flag disabled.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug