Bug 262779 - [GTK] Display VBlank monitor stops when the monitor is off
Summary: [GTK] Display VBlank monitor stops when the monitor is off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2023-10-06 05:03 PDT by Carlos Garcia Campos
Modified: 2023-10-06 06:40 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-10-06 05:03:35 PDT 
When the monitor we are using to get the vblank signal is off or suspended, drmWaitVBlank fails with -EPERM. That's considered fatal error and we stop sending the signal to the web process, so that when the monitor is back we don't get any display update. This only happens in the few cases in which the view is not notified to be non-visible, and the vblank monitor keeps running. In those cases we can just handle the error and keep trying after sleeping for a while until it successes again.
Comment 1 Carlos Garcia Campos 2023-10-06 05:08:10 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18759
Comment 2 EWS 2023-10-06 06:40:45 PDT 
Committed 268988@main (b727a1776a5f): <https://commits.webkit.org/268988@main>

Reviewed commits have been landed. Closing PR #18759 and removing active labels.