RESOLVED FIXED 262718
Introduce 'rotateRadians' helper function and use across WebKit 
https://bugs.webkit.org/show_bug.cgi?id=262718
Summary Introduce 'rotateRadians' helper function and use across WebKit
Ahmad Saleem
Reported 2023-10-05 12:39:09 PDT
Hi Team, While going through Blink commits, I came across a helper, which reduces few multiplication etc. Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=167603 (Helper function) and https://src.chromium.org/viewvc/blink?revision=168929&view=revision (Use in Canvas etc.) ___ If we add new rotateRadians function, we will be able to reduce unnecessary operations. Before : rad -> rad2deg -> deg2rad -> calc sinNcos After : rad -> calc sinNcos As a result, we can reduce two multiplication and two division. ___ It benefits by doing above. So just wanted to raise, so I can do PR. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
EWS
Comment 1 2023-10-05 20:50:53 PDT
Committed 268964@main (3f64447f2aa9): <https://commits.webkit.org/268964@main> Reviewed commits have been landed. Closing PR #18712 and removing active labels.
Radar WebKit Bug Importer
Comment 2 2023-10-05 20:51:15 PDT
<rdar://problem/116558684>
Note You need to log in before you can comment on or make changes to this bug.