Bug 262587 - WidthCache::SingleCharMap doesn't need to use 32 bits to store the key character
Summary: WidthCache::SingleCharMap doesn't need to use 32 bits to store the key character
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 262601
Blocks:
  Show dependency tree / graph
 
Reported: 2023-10-03 16:54 PDT by Chris Dumez
Modified: 2023-10-03 21:11 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-10-03 16:54:17 PDT 
WidthCache::SingleCharMap doesn't need to use 32 bits to store the key character. It is a UChar, which is guaranteed to be 16 bit.
Comment 1 Chris Dumez 2023-10-03 16:57:23 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18597
Comment 2 EWS 2023-10-03 20:21:25 PDT 
Committed 268822@main (ee2c3461bc42): <https://commits.webkit.org/268822@main>

Reviewed commits have been landed. Closing PR #18597 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-10-03 20:22:15 PDT 
<rdar://problem/116441712>
Comment 4 WebKit Commit Bot 2023-10-03 21:05:34 PDT 
Re-opened since this is blocked by bug 262601
Comment 5 Chris Dumez 2023-10-03 21:11:10 PDT 
Likely not safe.