Bug 262512 – REGRESSION(268723@main): Broke pyOpenSSL & Twisted

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

As can be seen in https://ews-build.webkit.org/#/builders/28/builds/20375, 268723@main has broken pyOpenSSL.

[Sam Sneddon [:gsnedders]]

This is gonna be caused by mismatched OpenSSL/cryptography versions.

pyOpenSSL 23.2.0, as now required, requires:

    cryptography>=38.0.0,<42,!=40.0.0,!=40.0.1

Whereas we have:

    AutoInstall.register(Package('cryptography', Version(36, 0, 2), wheel=True, implicit_deps=['cffi']))

As I wrote in https://bugs.webkit.org/show_bug.cgi?id=262369#c5, I do not understand how the configured set of packages could work in the WPE setup.

That said, I'm just going to add these behind a branch for 3.11 in the first instance, and let those who deal with the WPE setup deal with the rest of my confusion as to how this works there.

[Sam Sneddon [:gsnedders]]

Gonna fix the other regression from that commit here too:

(In reply to Sam Sneddon [:gsnedders] from comment #5)
> […]
> 
> The AutoInstaller _cannot_ install Twisted 23.8.0, because we don't support
> PEP 517 builders (Bug 261082). I think 22.10.0 is the latest version on PyPI
> the AutoInstaller should be able to install?
> 
> […]
> 
> This has, resultantly, broken certain internal CI jobs with a traceback
> ending in:
> 
>   File
> "/Volumes/Data/worker/ews-tools-trybot/build/OpenSource/Tools/Scripts/
> webkitpy/autoinstalled/buildbot.py", line 27, in <module>
>     from webkitpy.autoinstalled import twisted
>   File
> "/Volumes/Data/worker/ews-tools-trybot/build/OpenSource/Tools/Scripts/
> webkitpy/autoinstalled/twisted.py", line 43, in <module>
>     from twisted.protocols.tls import TLSMemoryBIOFactory
> ModuleNotFoundError: No module named 'twisted'
> 
> […]

[Radar WebKit Bug Importer]

<rdar://problem/116373366>

[Sam Sneddon [:gsnedders]]

Pull request: https://github.com/WebKit/WebKit/pull/18522

[EWS]

Committed 268757@main (c199bf81ac72): <https://commits.webkit.org/268757@main>

Reviewed commits have been landed. Closing PR #18522 and removing active labels.

[Carlos Alberto Lopez Perez]

Sorry for the mess I caused with this and thanks for the fixes!

I submitted bug 263299 to try to clean/improve this a bit more.