WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
262472
[Curl] Reduce unnecessary data conversions
https://bugs.webkit.org/show_bug.cgi?id=262472
Summary
[Curl] Reduce unnecessary data conversions
Kenji Shukuwa
Reported
2023-10-01 23:36:22 PDT
Currently, a SharedBuffer is generated in CurlRequest::didReceiveDataCallback when receiving data from libcurl. However, if CurlRequest::didReceiveData performs CURL_WRITEFUNC_PAUSE processing, this SharedBuffer will be discarded without being used. Also, CurlMultipartHandle::didReceiveMessage performs a SharedBuffer to Vector conversion. This is a wasteful data conversion. For this reason, avoid converting to SharedBuffer at the time of CurlRequest::didReceiveDataCallback.
Attachments
Add attachment
proposed patch, testcase, etc.
Kenji Shukuwa
Comment 1
2023-10-01 23:58:49 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/18486
EWS
Comment 2
2023-10-03 13:18:03 PDT
Committed
268801@main
(7ab6aab9c1b7): <
https://commits.webkit.org/268801@main
> Reviewed commits have been landed. Closing PR #18486 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-10-03 13:19:16 PDT
<
rdar://problem/116418404
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug