Bug 262460 – [Win] editing/selection/caret-rtl-right.html is randomly failing

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Fujii Hironori]

editing/selection/caret-rtl-right.html is randomly failing on WinCairo tester buildbots.

https://results.webkit.org/?suite=layout-tests&test=editing%2Fselection%2Fcaret-rtl-right.html

--- C:\BW\WinCairo-64-bit-Release-Tests\build\layout-test-results\editing/selection/caret-rtl-right-expected.txt
+++ C:\BW\WinCairo-64-bit-Release-Tests\build\layout-test-results\editing/selection/caret-rtl-right-actual.txt
@@ -11,7 +11,8 @@
         RenderText {#text} at (133,11) size 58x22
           text run at (133,11) width 58 RTL: "\x{5E9}\x{5D3}\x{5D4} \x{5D1}\x{5D5}\x{5E8}"
       RenderBlock (anonymous) at (0,101) size 784x20
-        RenderText {#text} at (0,0) size 37x19
-          text run at (0,0) width 37: "PASS"
-        RenderBR {BR} at (37,0) size 0x19
-caret: position 0 of child 0 {#text} of child 3 {DIV} of body
+        RenderText {#text} at (0,0) size 185x19
+          text run at (0,0) width 185: "FAIL: selection not collapsed"
+        RenderBR {BR} at (185,0) size 0x19
+selection start: position 0 of child 0 {#text} of child 3 {DIV} of body
+selection end:   position 3 of child 0 {#text} of child 3 {DIV} of body

However, this is not reprodusible on my PC.

[Fujii Hironori]

editing/selection/caret-ltr-right.html is also randomly failing.
https://build.webkit.org/results/WinCairo-64-bit-Release-Tests/268759@main%20(2306)/results.html

--- C:\BW\WinCairo-64-bit-Release-Tests\build\layout-test-results\editing/selection/caret-ltr-right-expected.txt
+++ C:\BW\WinCairo-64-bit-Release-Tests\build\layout-test-results\editing/selection/caret-ltr-right-actual.txt
@@ -11,7 +11,8 @@
         RenderText {#text} at (11,11) size 72x22
           text run at (11,11) width 72: "WebKit2"
       RenderBlock (anonymous) at (0,101) size 784x20
-        RenderText {#text} at (0,0) size 37x19
-          text run at (0,0) width 37: "PASS"
-        RenderBR {BR} at (37,0) size 0x19
-caret: position 7 of child 0 {#text} of child 3 {DIV} of body
+        RenderText {#text} at (0,0) size 185x19
+          text run at (0,0) width 185: "FAIL: selection not collapsed"
+        RenderBR {BR} at (185,0) size 0x19
+selection start: position 0 of child 0 {#text} of child 3 {DIV} of body
+selection end:   position 7 of child 0 {#text} of child 3 {DIV} of body

[Fujii Hironori]

Looking at the diffs,
in caret-rtl-right.html, the first word was selected.
in caret-ltr-right.html, the word "WebKit2" was selected.
It seems that a double click was happened to select the rightmost word.

[Fujii Hironori]

editing/selection/5057506.html is also failing only on the tester buildbot, and it seems to be a fake double-click to select a word.

[Fujii Hironori]

In sssel5057506.html, the word "foo" is selected.

https://build.webkit.org/results/WinCairo-64-bit-Release-Tests/268765@main%20(2308)/editing/selection/5057506-diff.txt

--- C:\BW\WinCairo-64-bit-Release-Tests\build\layout-test-results\editing/selection/5057506-expected.txt
+++ C:\BW\WinCairo-64-bit-Release-Tests\build\layout-test-results\editing/selection/5057506-actual.txt
@@ -26,5 +26,5 @@
         RenderBlock {DIV} at (0,30) size 784x20
           RenderText {#text} at (0,0) size 20x19
             text run at (0,0) width 20: "bar"
-selection start: position 3 of child 0 {#text} of child 0 {SPAN} of child 0 {TD} of child 0 {TR} of child 0 {TBODY} of child 1 {TABLE} of child 2 {DIV} of body
+selection start: position 0 of child 0 {#text} of child 0 {SPAN} of child 0 {TD} of child 0 {TR} of child 0 {TBODY} of child 1 {TABLE} of child 2 {DIV} of body
 selection end:   position 0 of child 3 {DIV} of child 2 {DIV} of body

[Radar WebKit Bug Importer]

<rdar://problem/116651981>

[Fujii Hironori]

I bought a new PC. Now, it's easy to reproduce this failire on my new PC.
> python .\Tools\Scripts\run-webkit-tests --debug --iterations=3 -v --no-retry-failures editing/selection/caret-rtl-right.html
It seems that a click event in the next page is considerd as a double click event.

[Fujii Hironori]

The following tests seem to have the same problem.

editing/deleting/smart-delete-001.html
editing/deleting/smart-delete-003.html
editing/deleting/smart-delete-004.html

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/18933

[EWS]

Committed 269217@main (d68b9530bdc4): <https://commits.webkit.org/269217@main>

Reviewed commits have been landed. Closing PR #18933 and removing active labels.