Bug 262421 - [update-test-expectations-from-bugzilla] don't use parse_known_args
Summary: [update-test-expectations-from-bugzilla] don't use parse_known_args
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-29 17:49 PDT by Sam Sneddon [:gsnedders]
Modified: 2023-10-02 11:37 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2023-09-29 17:49:42 PDT 
Similar to bug 259750, we should be using parse_args and not parse_known_args unless we have a very strong reason to use the latter.

As it is, we reimplement our own argument validation here which is just… silly.
Comment 1 Radar WebKit Bug Importer 2023-09-29 17:50:07 PDT 
<rdar://problem/116264336>
Comment 2 Sam Sneddon [:gsnedders] 2023-09-29 18:08:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18453
Comment 3 EWS 2023-10-02 11:37:53 PDT 
Committed 268738@main (5610a2924300): <https://commits.webkit.org/268738@main>

Reviewed commits have been landed. Closing PR #18453 and removing active labels.