WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
262407
Use `HashSet<CheckedRef<Range>>` instead of `WeakHashSet<Range>` for Document::m_ranges
https://bugs.webkit.org/show_bug.cgi?id=262407
Summary
Use `HashSet<CheckedRef<Range>>` instead of `WeakHashSet<Range>` for Document...
Chris Dumez
Reported
2023-09-29 15:03:07 PDT
Use `HashSet<CheckedRef<Range>>` instead of `WeakHashSet<Range>` for Document::m_ranges. The Range destructor takes care of removing itself from Document::m_ranges already so we don't need a WeakPtr. Using CheckedRef here is slightly more efficient.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2023-09-29 15:04:28 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/18441
EWS
Comment 2
2023-09-29 17:23:12 PDT
Committed
268680@main
(cbb5cdba4811): <
https://commits.webkit.org/268680@main
> Reviewed commits have been landed. Closing PR #18441 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-09-29 17:24:13 PDT
<
rdar://problem/116263456
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug