Bug 262395 - run-webkit-tests broken with python 3.12 due to error in beautifulsoup4
Summary: run-webkit-tests broken with python 3.12 due to error in beautifulsoup4
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-29 13:14 PDT by Michael Catanzaro
Modified: 2023-09-30 08:36 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-09-29 13:14:16 PDT
I'm unable to use run-webkit-tests due to some error in beautifulsoup4:

Traceback (most recent call last):
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/run-webkit-tests", line 35, in <module>
    from webkitpy.layout_tests.run_webkit_tests import main
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 39, in <module>
    from webkitpy.layout_tests.controllers.manager import Manager
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 54, in <module>
    from webkitpy.layout_tests.controllers.layout_test_runner import LayoutTestRunner
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 40, in <module>
    from webkitpy.layout_tests.controllers import single_test_runner
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 40, in <module>
    from webkitpy.w3c.test_parser import TestParser
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py", line 34, in <module>
    from webkitpy.thirdparty.BeautifulSoup import BeautifulSoup as Parser
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 27, in <module>
    import bs4
  File "<frozen importlib._bootstrap>", line 1354, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1316, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1256, in _find_spec
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 651, in find_spec
    loader = cls.find_module(fullname, path=path)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 665, in find_module
    cls.install(name)
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 638, in install
    return all([to_install.install() for to_install in packages])
                ^^^^^^^^^^^^^^^^^^^^
  File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 337, in install
    subprocess.check_call(
  File "/usr/lib64/python3.12/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', '/tmp/bs4-92584/beautifulsoup4-4.9.3/setup.py', 'install', '--home=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64', '--root=/', '--prefix=', '--install-lib=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64', '--install-scripts=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/bin', '--install-data=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/data', '--install-headers=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/headers']' returned non-zero exit status 1.

I can fix it by upgrading from beautifulsoup4 4.9.3 to 4.10.0, which drops compatibility with python2.
Comment 1 Michael Catanzaro 2023-09-29 13:16:51 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18430
Comment 2 EWS 2023-09-30 08:35:16 PDT
Committed 268694@main (00cd7de391a8): <https://commits.webkit.org/268694@main>

Reviewed commits have been landed. Closing PR #18430 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-30 08:36:14 PDT
<rdar://problem/116283991>