You need to
before you can comment on or make changes to this bug.
In order to eliminate the leakage of JSC into WebCore, introduced inhttp://trac.webkit.org/changeset/44452, move most of DateMath funcs into wtf/DateExtras. The remaining conversion funcs stay in DateConversion.
Created an attachment (id=31031) [details]
Introduce DateExtras, v1.
WebCore/ChangeLog | 17 +
WebCore/ForwardingHeaders/runtime/DateMath.h | 4 -
WebCore/ForwardingHeaders/wtf/DateExtras.h | 4 +
WebCore/platform/network/HTTPParsers.cpp | 9 +
WebCore/platform/network/HTTPParsers.h | 1 +
WebCore/platform/network/ResourceResponseBase.cpp | 4 +-
28 files changed, 1360 insertions(+), 1161 deletions(-)
You should probably use svn copy to preserve history for these moves.
(In reply to comment #0)
> In order to eliminate the leakage of JSC into WebCore, introduced
> in <http://trac.webkit.org/changeset/44452>, move most of DateMath funcs into
> wtf/DateExtras. The remaining conversion funcs stay in DateConversion.
(In reply to comment #2)
> You should probably use svn copy to preserve history for these moves.
I am not 100% sure, but I think git does this right when it commits. I'll research.
(In reply to comment #4)
> (In reply to comment #2)
> > You should probably use svn copy to preserve history for these moves.
> I am not 100% sure, but I think git does this right when it commits. I'll
git tries to get it right, but it uses a fuzzy algorithm rather than an absolute connection (as in svn). Most of the time it gets it wrong if it's a small file, e.g., where the license header is as-long-as or longer than the actual source. Then it thinks the new file is copied from a nonsensical original.
You're *probably* okay with using git in this case, but I'd strongly suggest using svn to make sure that the history is preserved.
(From update of attachment 31031 [details])
The other Extras.h headers are mostly to fill in holes in standard library implementations to smooth over platform differences. This seems a bit different in that it implements original functions that don't exist on any platform, so perhaps it should have a different name.
So I'm not sure I like the new name.
I can make it wtf/DateMath, if that's preferred, I have no opinion here. Let me know, and I'll make it happen. Would really like to land this soon -- we have fixes after this patch that we really would like to have without branching out.
I reworked the patch to:
* use svn cp (darn it! I don't like to admit when git is inferior)
* change DateExtras.h to wtf/DateMath.h
Created an attachment (id=31058) [details]
Move DateMath to WTF namespace, v2.
(From update of attachment 31058 [details])
rs=me if you're just moving code and you promise to watch the bots! :)