Bug 262300 - Remove BBC radio player quirk leftovers
Summary: Remove BBC radio player quirk leftovers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-28 04:39 PDT by Olivier Blin
Modified: 2023-10-03 05:25 PDT (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2023-09-28 04:39:35 PDT 
The BBC radio player quirk has been removed in 266597@main (9b58b4bed53b), which is a back-merge of 259548.824@safari-7615-branch (cff01e3).
But this commit did not remove the Quirks::staticRadioPlayerURLString() method initially removed, and a second quirk part added in 261190@main (ae690092de53) which is now irrelevant and potentially broken.

This also breaks build without ITP support.

See also the restricted bug 257352.
Comment 1 Olivier Blin 2023-09-28 04:47:42 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18339
Comment 2 EWS 2023-10-03 05:24:31 PDT 
Committed 268769@main (e0366ad8cf40): <https://commits.webkit.org/268769@main>

Reviewed commits have been landed. Closing PR #18339 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-10-03 05:25:15 PDT 
<rdar://problem/116397645>