Bug 26227 - Upstream V8 bindings for V8CustomXpathNSResolver
Summary: Upstream V8 bindings for V8CustomXpathNSResolver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-05 14:16 PDT by Nate Chapin
Modified: 2009-06-13 15:01 PDT (History)
2 users (show)

See Also:


Attachments
patch (8.36 KB, patch)
2009-06-05 14:19 PDT, Nate Chapin
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2009-06-05 14:16:56 PDT
See summary.
Comment 1 Nate Chapin 2009-06-05 14:19:20 PDT
Created attachment 31011 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2009-06-05 14:42:52 PDT
Comment on attachment 31011 [details]
patch

> +// Copyright (c) 2008, Google Inc.

(C) 2008 Google Inc. All rights reserved.

:)
Comment 3 Adam Barth 2009-06-13 11:14:02 PDT
Will land.
Comment 4 Adam Barth 2009-06-13 14:28:28 PDT
Sending        WebCore/ChangeLog
Adding         WebCore/bindings/v8/custom/V8CustomXPathNSResolver.cpp
Adding         WebCore/bindings/v8/custom/V8CustomXPathNSResolver.h
Sending        WebCore/bindings/v8/custom/V8DocumentCustom.cpp
Transmitting file data ....
Committed revision 44658.
Comment 5 Adam Barth 2009-06-13 15:01:44 PDT
Looks like you need to check in the downstream half of this change to fix the integration builder:

http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Mac%20(webkit.org)/builds/384/steps/compile/logs/stdio

I can roll the upstream patch back if you like, but that seems counter productive.