Bug 262186 - [IFC][Ruby] Resize annotation renderer after inline layout when needed
Summary: [IFC][Ruby] Resize annotation renderer after inline layout when needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-27 07:39 PDT by zalan
Modified: 2023-09-27 09:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2023-09-27 07:45 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (2.92 KB, patch)
2023-09-27 07:57 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-09-27 07:39:20 PDT 
ssia
Comment 1 zalan 2023-09-27 07:45:49 PDT 
Created attachment 467900 [details]
Patch
Comment 2 zalan 2023-09-27 07:57:34 PDT 
Created attachment 467901 [details]
[fast-cq]Patch
Comment 3 Antti Koivisto 2023-09-27 07:59:05 PDT 
Comment on attachment 467901 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467901&action=review

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:638
> +            renderer.setOverridingLogicalWidthLength({ usedMarginBoxSize.width(), LengthType::Fixed });

amazing
Comment 4 zalan 2023-09-27 08:54:12 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 467901 [details]
> [fast-cq]Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467901&action=review
> 
> > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:638
> > +            renderer.setOverridingLogicalWidthLength({ usedMarginBoxSize.width(), LengthType::Fixed });
> 
> amazing
the best!
Comment 5 EWS 2023-09-27 09:22:47 PDT 
Committed 268512@main (178cde2d00a3): <https://commits.webkit.org/268512@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467901 [details].
Comment 6 Radar WebKit Bug Importer 2023-09-27 09:23:12 PDT 
<rdar://problem/116125323>