RESOLVED FIXED 262186
[IFC][Ruby] Resize annotation renderer after inline layout when needed 
https://bugs.webkit.org/show_bug.cgi?id=262186
Summary [IFC][Ruby] Resize annotation renderer after inline layout when needed
zalan
Reported 2023-09-27 07:39:20 PDT
ssia
Attachments
Patch (2.86 KB, patch)
2023-09-27 07:45 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (2.92 KB, patch)
2023-09-27 07:57 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2023-09-27 07:45:49 PDT
Created attachment 467900 [details] Patch
zalan
Comment 2 2023-09-27 07:57:34 PDT
Created attachment 467901 [details] [fast-cq]Patch
Antti Koivisto
Comment 3 2023-09-27 07:59:05 PDT
Comment on attachment 467901 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467901&action=review > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:638 > + renderer.setOverridingLogicalWidthLength({ usedMarginBoxSize.width(), LengthType::Fixed }); amazing
zalan
Comment 4 2023-09-27 08:54:12 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 467901 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467901&action=review > > > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:638 > > + renderer.setOverridingLogicalWidthLength({ usedMarginBoxSize.width(), LengthType::Fixed }); > > amazing the best!
EWS
Comment 5 2023-09-27 09:22:47 PDT
Committed 268512@main (178cde2d00a3): <https://commits.webkit.org/268512@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467901 [details].
Radar WebKit Bug Importer
Comment 6 2023-09-27 09:23:12 PDT
<rdar://problem/116125323>
Note You need to log in before you can comment on or make changes to this bug.