Bug 26204 - RenderBlock : simplify handleSpecialChild, comment correction
Summary: RenderBlock : simplify handleSpecialChild, comment correction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P5 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-04 20:14 PDT by Roland Steiner
Modified: 2009-06-04 20:23 PDT (History)
0 users

See Also:


Attachments
patch - simplify method signatures and loop structure, fix comment (7.63 KB, patch)
2009-06-04 20:17 PDT, Roland Steiner
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2009-06-04 20:14:35 PDT
[separated out from bug #26198]

simplify the handleSpecialChild and its related methods
(handlePositionedChild, handleFloatingChild, handleRunInChild).

There is also a typo in a clarifying remark ('maxPosNeg' instead of 'maxTopNeg')
Comment 1 Roland Steiner 2009-06-04 20:17:11 PDT
Created attachment 30985 [details]
patch - simplify method signatures and loop structure, fix comment
Comment 2 Eric Seidel (no email) 2009-06-04 20:23:01 PDT
Comment on attachment 30985 [details]
patch - simplify method signatures and loop structure, fix comment

Fantastic!  (You didn't actually need to make this its own bug, but it's nice that you did.)  

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderBlock.cpp
	M	WebCore/rendering/RenderBlock.h
Committed r44446