WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26204
RenderBlock : simplify handleSpecialChild, comment correction
https://bugs.webkit.org/show_bug.cgi?id=26204
Summary
RenderBlock : simplify handleSpecialChild, comment correction
Roland Steiner
Reported
2009-06-04 20:14:35 PDT
[separated out from
bug #26198
] simplify the handleSpecialChild and its related methods (handlePositionedChild, handleFloatingChild, handleRunInChild). There is also a typo in a clarifying remark ('maxPosNeg' instead of 'maxTopNeg')
Attachments
patch - simplify method signatures and loop structure, fix comment
(7.63 KB, patch)
2009-06-04 20:17 PDT
,
Roland Steiner
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Roland Steiner
Comment 1
2009-06-04 20:17:11 PDT
Created
attachment 30985
[details]
patch - simplify method signatures and loop structure, fix comment
Eric Seidel (no email)
Comment 2
2009-06-04 20:23:01 PDT
Comment on
attachment 30985
[details]
patch - simplify method signatures and loop structure, fix comment Fantastic! (You didn't actually need to make this its own bug, but it's nice that you did.) Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/rendering/RenderBlock.cpp M WebCore/rendering/RenderBlock.h Committed
r44446
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug