RESOLVED FIXED 26201
Remove superfluous 'if' statements in RenderTable::addChild 
https://bugs.webkit.org/show_bug.cgi?id=26201
Summary Remove superfluous 'if' statements in RenderTable::addChild
Roland Steiner
Reported 2009-06-04 19:34:54 PDT
[separated out from bug #26198] RenderTable::addChild has a few superfluous 'if' statements (the same condition is queried at the start of the block already)
Attachments
patch - remove superfluous 'if's (3.18 KB, patch)
2009-06-04 19:56 PDT, Roland Steiner 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2009-06-04 19:56:43 PDT
Created attachment 30981 [details] patch - remove superfluous 'if's
Eric Seidel (no email)
Comment 2 2009-06-04 20:27:14 PDT
Comment on attachment 30981 [details] patch - remove superfluous 'if's Would still be preferred to add ASSERTs here and fix the extra { } while where here.
Eric Seidel (no email)
Comment 3 2009-06-04 20:45:16 PDT
Comment on attachment 30981 [details] patch - remove superfluous 'if's Looks good. The ASSERT() doens't really buy us much. So much else would break if we changed away from RenderTableSection anyway.
Eric Seidel (no email)
Comment 4 2009-06-04 20:46:08 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderTable.cpp Committed r44450
Note You need to log in before you can comment on or make changes to this bug.