Bug 26201 - Remove superfluous 'if' statements in RenderTable::addChild
Summary: Remove superfluous 'if' statements in RenderTable::addChild
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P5 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-04 19:34 PDT by Roland Steiner
Modified: 2009-06-04 20:46 PDT (History)
0 users

See Also:


Attachments
patch - remove superfluous 'if's (3.18 KB, patch)
2009-06-04 19:56 PDT, Roland Steiner
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2009-06-04 19:34:54 PDT
[separated out from bug #26198]

RenderTable::addChild has a few superfluous 'if' statements (the same condition is queried at the start of the block already)
Comment 1 Roland Steiner 2009-06-04 19:56:43 PDT
Created attachment 30981 [details]
patch - remove superfluous 'if's
Comment 2 Eric Seidel (no email) 2009-06-04 20:27:14 PDT
Comment on attachment 30981 [details]
patch - remove superfluous 'if's

Would still be preferred to add ASSERTs here and fix the extra { } while where here.
Comment 3 Eric Seidel (no email) 2009-06-04 20:45:16 PDT
Comment on attachment 30981 [details]
patch - remove superfluous 'if's

Looks good.  The ASSERT() doens't really buy us much.  So much else would break if we changed away from RenderTableSection anyway.
Comment 4 Eric Seidel (no email) 2009-06-04 20:46:08 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderTable.cpp
Committed r44450