Bug 26200 - [Chromium] Auto Spell Correct in Chromium makes cursor jump arbitrarily in text boxes already having text
: [Chromium] Auto Spell Correct in Chromium makes cursor jump arbitrarily in te...
Status: RESOLVED FIXED
: WebKit
HTML Editing
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-06-04 17:16 PST by
Modified: 2009-06-24 15:05 PST (History)


Attachments
Patch to fix cursor behavior (1.23 KB, patch)
2009-06-04 17:21 PST, Siddhartha Chattopadhyay
eric: review-
Review Patch | Details | Formatted Diff | Diff
Patch 2 to fix caret position after auto correction of word (2.01 KB, patch)
2009-06-05 10:41 PST, Siddhartha Chattopadhyay
no flags Review Patch | Details | Formatted Diff | Diff
Patch 2 to fix caret position after auto correct (2.46 KB, patch)
2009-06-05 10:47 PST, Siddhartha Chattopadhyay
eric: review-
Review Patch | Details | Formatted Diff | Diff
Also add a manual test (2.81 KB, patch)
2009-06-12 16:41 PST, Siddhartha Chattopadhyay
eric: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-06-04 17:16:08 PST
In order to repro this in Chromium, click on a reply email in Gmail and type in a mispelled word. The curson jumps to an arbitrary position.
------- Comment #1 From 2009-06-04 17:21:58 PST -------
Created an attachment (id=30976) [details]
Patch to fix cursor behavior
------- Comment #2 From 2009-06-04 20:16:13 PST -------
(From update of attachment 30976 [details])
This needs a manual test.
Your ChangeLog has tabs in it (which makes it unlandable).
Your ChangeLog shoudl have a better description of what is actually being fixed here :)
------- Comment #3 From 2009-06-05 10:41:20 PST -------
Created an attachment (id=31003) [details]
Patch 2 to fix caret position after auto correction of word
------- Comment #4 From 2009-06-05 10:47:30 PST -------
Created an attachment (id=31004) [details]
Patch 2 to fix caret position after auto correct
------- Comment #5 From 2009-06-12 11:32:24 PST -------
(From update of attachment 31004 [details])
This only needs one ChangeLog.  It also needs a manual test still.  WebCore/manual-tests.  Also, patches won't get reviewed until they're marked r=?  see http://webkit.org/coding/contributing.html
------- Comment #6 From 2009-06-12 16:41:07 PST -------
Created an attachment (id=31221) [details]
Also add a manual test
------- Comment #7 From 2009-06-14 02:27:49 PST -------
(From update of attachment 31221 [details])
Looks fine.  Seems we might need to start adding a platform/ directory to the manual-tests :)
------- Comment #8 From 2009-06-15 10:58:49 PST -------
Great - if it is alright with you, could you please submit the patch for me? I do not have commit access. Thanks.

-Sid

(In reply to comment #7)
> (From update of attachment 31221 [details] [review])
> Looks fine.  Seems we might need to start adding a platform/ directory to the
> manual-tests :)
> 
------- Comment #9 From 2009-06-18 14:47:29 PST -------
(From update of attachment 31221 [details])
LGTM.
------- Comment #10 From 2009-06-24 01:06:07 PST -------
(From update of attachment 31221 [details])
Tabs in the ChangeLog.  Will have to land this manually.
------- Comment #11 From 2009-06-24 01:12:28 PST -------
Committing to http://svn.webkit.org/repository/webkit/trunk ...
    M    WebCore/ChangeLog
    M    WebCore/editing/Editor.cpp
    A    WebCore/manual-tests/textarea-caret-position-after-auto-spell-correct.html
Committed r45075
http://trac.webkit.org/changeset/45075
------- Comment #12 From 2009-06-24 15:05:36 PST -------
Thanx !

(In reply to comment #11)
> Committing to http://svn.webkit.org/repository/webkit/trunk ...
>         M       WebCore/ChangeLog
>         M       WebCore/editing/Editor.cpp
>         A      
> WebCore/manual-tests/textarea-caret-position-after-auto-spell-correct.html
> Committed r45075
> http://trac.webkit.org/changeset/45075
>