RESOLVED FIXED 26200
[Chromium] Auto Spell Correct in Chromium makes cursor jump arbitrarily in text boxes already having text 
https://bugs.webkit.org/show_bug.cgi?id=26200
Summary [Chromium] Auto Spell Correct in Chromium makes cursor jump arbitrarily in te...
Siddhartha Chattopadhyay
Reported 2009-06-04 17:16:08 PDT
In order to repro this in Chromium, click on a reply email in Gmail and type in a mispelled word. The curson jumps to an arbitrary position.
Attachments
Patch to fix cursor behavior (1.23 KB, patch)
2009-06-04 17:21 PDT, Siddhartha Chattopadhyay 		eric: review-
DetailsFormatted DiffDiff
Patch 2 to fix caret position after auto correction of word (2.01 KB, patch)
2009-06-05 10:41 PDT, Siddhartha Chattopadhyay 		no flags
DetailsFormatted DiffDiff
Patch 2 to fix caret position after auto correct (2.46 KB, patch)
2009-06-05 10:47 PDT, Siddhartha Chattopadhyay 		eric: review-
DetailsFormatted DiffDiff
Also add a manual test (2.81 KB, patch)
2009-06-12 16:41 PDT, Siddhartha Chattopadhyay 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Siddhartha Chattopadhyay
Comment 1 2009-06-04 17:21:58 PDT
Created attachment 30976 [details] Patch to fix cursor behavior
Eric Seidel (no email)
Comment 2 2009-06-04 20:16:13 PDT
Comment on attachment 30976 [details] Patch to fix cursor behavior This needs a manual test. Your ChangeLog has tabs in it (which makes it unlandable). Your ChangeLog shoudl have a better description of what is actually being fixed here :)
Siddhartha Chattopadhyay
Comment 3 2009-06-05 10:41:20 PDT
Created attachment 31003 [details] Patch 2 to fix caret position after auto correction of word
Siddhartha Chattopadhyay
Comment 4 2009-06-05 10:47:30 PDT
Created attachment 31004 [details] Patch 2 to fix caret position after auto correct
Eric Seidel (no email)
Comment 5 2009-06-12 11:32:24 PDT
Comment on attachment 31004 [details] Patch 2 to fix caret position after auto correct This only needs one ChangeLog. It also needs a manual test still. WebCore/manual-tests. Also, patches won't get reviewed until they're marked r=? see http://webkit.org/coding/contributing.html
Siddhartha Chattopadhyay
Comment 6 2009-06-12 16:41:07 PDT
Created attachment 31221 [details] Also add a manual test
Eric Seidel (no email)
Comment 7 2009-06-14 02:27:49 PDT
Comment on attachment 31221 [details] Also add a manual test Looks fine. Seems we might need to start adding a platform/ directory to the manual-tests :)
Siddhartha Chattopadhyay
Comment 8 2009-06-15 10:58:49 PDT
Great - if it is alright with you, could you please submit the patch for me? I do not have commit access. Thanks. -Sid (In reply to comment #7) > (From update of attachment 31221 [details] [review]) > Looks fine. Seems we might need to start adding a platform/ directory to the > manual-tests :) >
Eric Seidel (no email)
Comment 9 2009-06-18 14:47:29 PDT
Comment on attachment 31221 [details] Also add a manual test LGTM.
Eric Seidel (no email)
Comment 10 2009-06-24 01:06:07 PDT
Comment on attachment 31221 [details] Also add a manual test Tabs in the ChangeLog. Will have to land this manually.
Eric Seidel (no email)
Comment 11 2009-06-24 01:12:28 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/editing/Editor.cpp A WebCore/manual-tests/textarea-caret-position-after-auto-spell-correct.html Committed r45075 http://trac.webkit.org/changeset/45075
Siddhartha Chattopadhyay
Comment 12 2009-06-24 15:05:36 PDT
Thanx ! (In reply to comment #11) > Committing to http://svn.webkit.org/repository/webkit/trunk ... > M WebCore/ChangeLog > M WebCore/editing/Editor.cpp > A > WebCore/manual-tests/textarea-caret-position-after-auto-spell-correct.html > Committed r45075 > http://trac.webkit.org/changeset/45075 >
Note You need to log in before you can comment on or make changes to this bug.