Bug 261986 – [CSS-Sizing] Block size with max-content and min-content in a table

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ahmad Saleem]

Hi Team,

While going through Blink's commit, I came across fix for two failing WPT in CSS-Sizing:

Link: http://wpt.live/css/css-sizing/block-size-with-min-or-max-content-table-1b.html & http://wpt.live/css/css-sizing/block-size-with-min-or-max-content-table-1a.html

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/3a0c4adda19bade345ca115fdcfe825acf0b8869

^ Only doing partial merge of 'RenderTable.cpp', make us pass above two tests in my local build.

Line 532:

if (logicalMaxHeightLength.isFillAvailable() || (logicalMaxHeightLength.isSpecified() && !logicalMaxHeightLength.isNegative() && !logicalMaxHeightLength.isMinContent() && !logicalMaxHeightLength.isMaxContent() && !logicalMaxHeightLength.isFitContent()))

Line 538 (new to add):

if (logicalMinHeightLength.isMinContent() || logicalMinHeightLength.isMaxContent() || logicalMinHeightLength.isFitContent())
            logicalMinHeightLength = LengthType::Auto;

___

I have this patch in local since long and haven't had any issue.

Just raising so I can fix it later. Adding 'BrowserCompat' since only Safari / WebKit is failing these tests and 'WPTImpact' tag due to tests being on WPT.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/116264670>

[Ahmad Saleem]

Second PR Attempt (with now wpt test import) - https://github.com/WebKit/WebKit/pull/19699

Thanks to Tim. :-)

[EWS]

Committed 271054@main (e180ca76e7e0): <https://commits.webkit.org/271054@main>

Reviewed commits have been landed. Closing PR #19699 and removing active labels.