The PlatformContextSkia constructor does a (very likely) wrong size initialization for its m_stateStack member: m_stateStack(sizeof(State)) The intended initialization is probably rather m_stateStack(1)
Created attachment 30962 [details] patch correcting the member variable initialization
Created attachment 30969 [details] PlatformContextSkia : fix member initialization (fixed .patch) (fixed .patch format, otherwise same as above)
Created attachment 30971 [details] ChangeLog entry
Comment on attachment 30969 [details] PlatformContextSkia : fix member initialization (fixed .patch) I suggest we remove the initialization all together. Vector will do the right thing by itself, we don't need to tell it to only allocate 1 slot by default.
(In reply to comment #4) I'm ok with that. It only occurred to me while browsing the code - I didn't question (or even research) the motivation behind it.
Comment on attachment 30971 [details] ChangeLog entry removed the r? from the changelog entry.
Created attachment 30988 [details] patch - remove variable initialization cf. comment #4
Comment on attachment 30988 [details] patch - remove variable initialization I would have just copied my comment instead of citing it. :) But looks great!
(In reply to comment #8) Thanks - as I'm not a committer (yet!), could you please commit this for me as well? Cheers, Roland
Landed in @r44576. Please don't remove the "Review by NOBODY (OOPS!)" from the ChangeLog.