Bug 261914 - [css-shapes] Don't serialize `at <position>` in circle/ellipse if unspecified
Summary: [css-shapes] Don't serialize `at <position>` in circle/ellipse if unspecified
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-21 16:11 PDT by Tim Nguyen (:ntim)
Modified: 2023-09-22 16:50 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-09-21 16:11:28 PDT 
...
Comment 1 Radar WebKit Bug Importer 2023-09-21 16:11:40 PDT 
<rdar://problem/115866108>
Comment 2 Tim Nguyen (:ntim) 2023-09-21 17:10:48 PDT Comment hidden (obsolete)
Comment 3 Tim Nguyen (:ntim) 2023-09-21 18:18:20 PDT 
Omitting `at 50% 50%` isn't the right thing to do, we should rather only omit the position if unspecified. (Unspecified != 50% 50% since unspecified will fallback to offset-position)
Comment 4 Tim Nguyen (:ntim) 2023-09-22 13:48:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18099
Comment 5 EWS 2023-09-22 16:49:59 PDT 
Committed 268344@main (eed95a0f3f2d): <https://commits.webkit.org/268344@main>

Reviewed commits have been landed. Closing PR #18099 and removing active labels.