Bug 26191 - We should not need to include xmath.h
Summary: We should not need to include xmath.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-04 10:41 PDT by Dimitri Glazkov (Google)
Modified: 2009-06-12 15:42 PDT (History)
1 user (show)

See Also:

Attachments
Remove xmath, v1. (956 bytes, patch)
2009-06-04 10:44 PDT, Dimitri Glazkov (Google) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-06-04 10:41:42 PDT 
Per http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=361804, we shouldn't need to include <xmath.h> in MathExtras.h

This in turn breaks VS2008 builds with TR1 turned on.
Comment 1 Dimitri Glazkov (Google) 2009-06-04 10:44:16 PDT 
Created attachment 30951 [details]
Remove xmath, v1.

 JavaScriptCore/ChangeLog        |   10 ++++++++++
 JavaScriptCore/wtf/MathExtras.h |    2 --
 2 files changed, 10 insertions(+), 2 deletions(-)
Comment 2 Eric Seidel (no email) 2009-06-04 20:17:34 PDT 
Comment on attachment 30951 [details]
Remove xmath, v1.

Assuming you're going to watch and make sure you didn't break the Windows bot, then this is OK with me.
Comment 3 Eric Seidel (no email) 2009-06-12 15:16:53 PDT 
Success!
Comment 4 Eric Seidel (no email) 2009-06-12 15:17:34 PDT 
Bah, sorry.  My commit-script went amuck.
Comment 5 Eric Seidel (no email) 2009-06-12 15:42:07 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/MathExtras.h
Committed r44633
	M	JavaScriptCore/wtf/MathExtras.h
	M	JavaScriptCore/ChangeLog
r44633 = c2c22c62a94efb33933a7dddfceebe1899f6f229 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
Comment 6 Eric Seidel (no email) 2009-06-12 15:42:54 PDT 
Tada!  My commit script worked!!!  bug 26283