RESOLVED FIXED 261900
[IFC][Ruby] Implement overhangForAnnotationBefore/overhangForAnnotationAfter
https://bugs.webkit.org/show_bug.cgi?id=261900
Summary [IFC][Ruby] Implement overhangForAnnotationBefore/overhangForAnnotationAfter
zalan
Reported 2023-09-21 12:26:17 PDT
ssia
Attachments
Patch (8.22 KB, patch)
2023-09-21 12:34 PDT, zalan
no flags
[fast-cq]Patch (8.22 KB, patch)
2023-09-22 13:35 PDT, zalan
no flags
zalan
Comment 1 2023-09-21 12:34:16 PDT
Antti Koivisto
Comment 2 2023-09-22 01:48:15 PDT
Comment on attachment 467817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467817&action=review > Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:157 > + if (!annotationBox || rubyBaseContentEndIndex == boxes.size() -1) space missing after -
zalan
Comment 3 2023-09-22 13:35:55 PDT
Created attachment 467828 [details] [fast-cq]Patch
EWS
Comment 4 2023-09-22 19:33:23 PDT
Committed 268351@main (867fce02ad07): <https://commits.webkit.org/268351@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467828 [details].
Radar WebKit Bug Importer
Comment 5 2023-09-22 19:34:13 PDT
Note You need to log in before you can comment on or make changes to this bug.