Bug 261838 – AX: AccessibilityObject::listMarkerTextForNodeAndPosition forces resolution of Position to VisiblePosition even when it's not used

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

It can be expensive to turn a Position into a VisiblePosition. We should only do it when necessary.

[Radar WebKit Bug Importer]

<rdar://problem/115801743>

[Tyler Wilcock]

Created attachment 467794 [details]
Patch

[chris fleizach]

Comment on attachment 467794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467794&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:1704
> +    return listItem ? listMarkerText(*listItem, WTFMove(startPosition)) : StringView();

does this work

return listItem ? listMarkerText(*listItem, WTFMove(startPosition)) : { };

[Tyler Wilcock]

(In reply to chris fleizach from comment #3)
> Comment on attachment 467794 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467794&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:1704
> > +    return listItem ? listMarkerText(*listItem, WTFMove(startPosition)) : StringView();
> 
> does this work
> 
> return listItem ? listMarkerText(*listItem, WTFMove(startPosition)) : { };
It doesn't compile unfortunately. C++ doesn't allow you to have the curly-brace initializer on the right side of a ternary.

/Users/twilco/projects/web/OpenSource/Source/WebCore/accessibility/AccessibilityObject.cpp:1710:71: error: initializer list cannot be used on the right hand side of operator ':'
    return listItem ? listMarkerText(*listItem, startVisiblePosition) : { };

[chris fleizach]

(In reply to Tyler Wilcock from comment #4)
> (In reply to chris fleizach from comment #3)
> > Comment on attachment 467794 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=467794&action=review
> > 
> > > Source/WebCore/accessibility/AccessibilityObject.cpp:1704
> > > +    return listItem ? listMarkerText(*listItem, WTFMove(startPosition)) : StringView();
> > 
> > does this work
> > 
> > return listItem ? listMarkerText(*listItem, WTFMove(startPosition)) : { };
> It doesn't compile unfortunately. C++ doesn't allow you to have the
> curly-brace initializer on the right side of a ternary.
> 
> /Users/twilco/projects/web/OpenSource/Source/WebCore/accessibility/
> AccessibilityObject.cpp:1710:71: error: initializer list cannot be used on
> the right hand side of operator ':'
>     return listItem ? listMarkerText(*listItem, startVisiblePosition) : { };

sad face emoji

[EWS]

Found 1 new test failure: imported/w3c/web-platform-tests/css/css-transitions/changing-while-transition-001.html

[EWS]

Committed 268239@main (42da7d77805d): <https://commits.webkit.org/268239@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467794 [details].