WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26183
[@font-face] font-family descriptor with multiple names should be discarded
https://bugs.webkit.org/show_bug.cgi?id=26183
Summary
[@font-face] font-family descriptor with multiple names should be discarded
Philippe Wittenbergh
Reported
2009-06-03 22:02:37 PDT
The linked page specifies an @font-face rule as: @font-face { font-family :'myfont', serif; src: 'myfont.ttf'; } p {font-family: 'myfont'; }
http://dev.w3.org/csswg/css3-fonts/#font-family0
(latest editor draft) specifies font-family in a @font-face rule as Value: <family-name> only one <family-name> is allowed. On the testcase: Actual result: the font specified in the @font-face rule is used Expected: the default font is used. Gecko (INVALID) bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=496128
see the last two comments there. Opera 10b also suffers from the same issue.
Attachments
Patch
(5.75 KB, patch)
2010-09-17 00:57 PDT
,
Yuzo Fujishima
no flags
Details
Formatted Diff
Diff
Patch
(6.99 KB, patch)
2010-09-20 23:11 PDT
,
Yuzo Fujishima
no flags
Details
Formatted Diff
Diff
Resolve merge conflict
(6.95 KB, patch)
2010-12-06 00:37 PST
,
Yuzo Fujishima
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Yuzo Fujishima
Comment 1
2010-09-17 00:57:02 PDT
Created
attachment 67890
[details]
Patch
mitz
Comment 2
2010-09-17 01:29:45 PDT
Comment on
attachment 67890
[details]
Patch Seems like this would break tests that use platform/win/css2.1/resources/Mac-compatible-font-fallback.css.
Yuzo Fujishima
Comment 3
2010-09-20 23:11:37 PDT
Created
attachment 68190
[details]
Patch
Yuzo Fujishima
Comment 4
2010-09-20 23:18:50 PDT
Thank you for the review. (In reply to
comment #2
)
> (From update of
attachment 67890
[details]
) > Seems like this would break tests that use platform/win/css2.1/resources/Mac-compatible-font-fallback.css.
Rewrote the rules not to specify multiple families. I didn't test it locally because running layout tests on Windows requires non-free font manipulation tool(s) as far as I can tell from
http://trac.webkit.org/wiki/BuildingOnWindows
I did search the files under LayoutTests and confirmed that I don't need to change other files.
Yuzo Fujishima
Comment 5
2010-10-29 00:12:55 PDT
Ping?
Yuzo Fujishima
Comment 6
2010-11-21 22:21:06 PST
Ping again?
Alexey Proskuryakov
Comment 7
2010-11-22 12:58:14 PST
Did you find a way to run regression tests?
Eric Seidel (no email)
Comment 8
2010-12-03 10:53:37 PST
Comment on
attachment 68190
[details]
Patch Seems reasonable to me. The cq will run layout tests if that was the above concern? I'll set r+ and someone else can set cq+ to have the tests run and landed.
WebKit Commit Bot
Comment 9
2010-12-05 18:19:00 PST
Comment on
attachment 68190
[details]
Patch Rejecting patch 68190 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 68190]" exit_code: 2 Last 500 characters of output: escriptor.html patching file LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/css/CSSParser.cpp Hunk #1 FAILED at 5493. Hunk #2 succeeded at 5573 (offset 73 lines). 1 out of 2 hunks FAILED -- saving rejects to file WebCore/css/CSSParser.cpp.rej Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output:
http://queues.webkit.org/results/6776048
Yuzo Fujishima
Comment 10
2010-12-06 00:37:09 PST
Created
attachment 75655
[details]
Resolve merge conflict
WebKit Commit Bot
Comment 11
2010-12-06 01:35:14 PST
Comment on
attachment 75655
[details]
Resolve merge conflict Rejecting patch 75655 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 75655]" exit_code: 1 Last 500 characters of output: 75655&action=edit Fetching:
https://bugs.webkit.org/show_bug.cgi?id=26183
&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 75655 from
bug 26183
. NOBODY (OOPS!) found in /Projects/CommitQueue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Projects/CommitQueue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/6748071
Yuzo Fujishima
Comment 12
2010-12-06 02:30:45 PST
Update the patch to resolve merge conflict. Can you review again?
Eric Seidel (no email)
Comment 13
2010-12-09 23:36:53 PST
Comment on
attachment 75655
[details]
Resolve merge conflict OK.
WebKit Commit Bot
Comment 14
2010-12-10 01:58:24 PST
Comment on
attachment 75655
[details]
Resolve merge conflict Rejecting patch 75655 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: env YACC /Developer/usr/bin/yacc /bin/sh -c /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Script-5DF50887116F3077005202AB.sh ** BUILD FAILED ** The following build commands failed: WebCore: CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/DOMSVGAnimatedInteger.o /Projects/CommitQueue/WebKitBuild/Debug/DerivedSources/WebCore/DOMSVGAnimatedInteger.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2 (1 failure) Full output:
http://queues.webkit.org/results/7025005
Eric Seidel (no email)
Comment 15
2010-12-14 01:24:42 PST
Comment on
attachment 68190
[details]
Patch Cleared Eric Seidel's review+ from obsolete
attachment 68190
[details]
so that this bug does not appear in
http://webkit.org/pending-commit
.
Eric Seidel (no email)
Comment 16
2010-12-20 22:47:45 PST
Comment on
attachment 75655
[details]
Resolve merge conflict Looks like a cq flake.
WebKit Commit Bot
Comment 17
2010-12-20 23:30:24 PST
Comment on
attachment 75655
[details]
Resolve merge conflict Clearing flags on attachment: 75655 Committed
r74401
: <
http://trac.webkit.org/changeset/74401
>
WebKit Commit Bot
Comment 18
2010-12-20 23:30:32 PST
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 19
2010-12-20 23:33:40 PST
Have you tested against the relevant tests in the CSS 2.1 test suite? <
http://test.csswg.org/suites/css2.1/20100917/
>
Yuzo Fujishima
Comment 20
2011-01-05 01:35:48 PST
(In reply to
comment #19
)
> Have you tested against the relevant tests in the CSS 2.1 test suite? <
http://test.csswg.org/suites/css2.1/20100917/
>
No. I don't see any tests that are very relevant to this patch there. Comma-separated font-family "properties" (not "descriptor") seem to be working, as in
http://test.csswg.org/suites/css2.1/20100917/html4/c522-font-family-000.htm
. Any specific tests you are interested in testing?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug